feat(sdk-core): add removePasskeyFromWallet function#8646
Draft
feat(sdk-core): add removePasskeyFromWallet function#8646
Conversation
Pure cryptographic primitives for WebAuthn PRF-based key derivation: - derivePassword: converts ArrayBuffer PRF result to hex walletPassphrase - deriveEnterpriseSalt: HMAC-SHA256 via SJCL matching retail implementation exactly TICKET: WCN-186
derranW26
force-pushed
the
passkey/ticket-5-remove-passkey-from-wallet
branch
from
895e229 to
f01d766
Compare
derranW26
changed the base branch from
master
to
WCN-186/passkey-crypto-package
derranW26
changed the base branch from
WCN-186/passkey-crypto-package
to
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removePasskeyFromWallet()tomodules/sdk-core/src/bitgo/passkey/decrypt()before issuing any DELETE — wrong passphrase aborts cleanly with no side effects/api/v2/key/{keychainId}/webauthndevice/{device.id}using MongoDB ObjectId (not credentialId)WebAuthnOtpDevicetype stub (to be replaced with@bitgo/public-typesonce that PR merges)Test plan
device.idencryptedPrv— verifies descriptive error thrown, no decrypt or DELETE calledTICKET: WCN-190